Skip to content

docs: Updated references to React documentation #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

stanleyoos
Copy link
Contributor

No description provided.

@stanleyoos stanleyoos self-assigned this Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit ea06d0c
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/66ced520ca2cc900086bfd78
😎 Deploy Preview https://deploy-preview-1362--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@satya164 satya164 force-pushed the main branch 2 times, most recently from 7dbaa57 to 9e2af9d Compare August 8, 2024 00:32
@stanleyoos stanleyoos requested a review from tboba August 12, 2024 08:23
@tboba tboba changed the title docs: Updated link to react context docs: Updated references to React documentation Aug 12, 2024
@tboba
Copy link

tboba commented Aug 12, 2024

Also, I see in some places in code there are still references to reactjs.org. I think we should also change them. What do you think?

@stanleyoos
Copy link
Contributor Author

@tboba I updated only v6 and v7 intentionally, since v5 is ~4 years old, do you think we should update all links?

@tboba
Copy link

tboba commented Aug 12, 2024

No no, I mean that in 6.x and 7.x versions there are still references to reactjs.org, like in function-after-focusing-screen.md article, there are references to intro for hooks guide. If you're using VSCode, you can cmd-shift-f on the project and look for reactjs.org - this way you could check if any articles from versioned_docs/version-6.x or versioned_docs/version-7.x still contain any references to reactjs.org 😄

@stanleyoos stanleyoos requested a review from tboba August 13, 2024 08:19
@stanleyoos stanleyoos requested a review from tboba August 14, 2024 06:04
Copy link

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@stanleyoos stanleyoos merged commit b3e51d9 into main Aug 28, 2024
3 checks passed
@stanleyoos stanleyoos deleted the @stanleyoos/docs-update-react-context-link branch August 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants